@itdependsnetworks we would need this patch for Nautobot 1.x and 2.x.

We should not, there was a change in nautobot core in 2.0, so in 1.6 it should be fine (I reserve the right to be proven wrong), this was an issue in 3 places, I only caught 1 of them. We should update core, as this is likely to happen again unless there is clear methods that have it properly scrubbed.

Is nautobot.core.utils.logging.sanitize() not doing the right thing in this case? It should be applied to all job logs in 2.0 automatically.

Need to personally test hopefully @jeffkala will as well :)

Test is to remove SANITIZER_PATTERNS and see if it strips.

To be honest, testing with SANITIZER_PATTERNS = [] with the develop branch (meaning the currently released code) I don't see anything in the logs in the first place.
However; testing this PR specifically with SANITIZER_PATTERNS = [] results in a failure in the repo push.

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/celery/app/trace.py", line 477, in trace_task
    R = retval = fun(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/nautobot/extras/jobs.py", line 148, in __call__
    return self.run(*args, **deserialized_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/source/nautobot_golden_config/jobs.py", line 181, in run
    git_info = get_repo_from_url_to_path_and_from_branch(backup_repo)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/nautobot/extras/datasources/git.py", line 88, in get_repo_from_url_to_path_and_from_branch
    from_url = repository_record.remote_url
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'GitRepo' object has no attribute 'remote_url'

So appears that get_refreshed_repos which the new code is looping over is actually creating from nautobot_golden_config.utilities.git import GitRepo which is not the repo objects from nautobot that the get_repo_from_url_to_path_and_from_branch function is expecting.